Skip to content

Improve single gnss enable/check #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Improve single gnss enable/check #190

merged 2 commits into from
Oct 9, 2023

Conversation

hybridOL
Copy link

@hybridOL hybridOL commented Apr 1, 2023

The loop can be exited once a match is found, as only one match will be found

@PaulZC
Copy link
Collaborator

PaulZC commented Apr 3, 2023

Hi @hybridOL ,

Thanks for submitting this pull request. I will merge it into the next release.

When you have time, please add your comments to #188 . Do you want to go forward with the 'list' or the 'array' idea? The array makes it easier to implement the isGNSSenabled method.

Best wishes,
Paul

@PaulZC
Copy link
Collaborator

PaulZC commented Oct 9, 2023

Hi @hybridOL ,

Apologies for the delay!!

Merging...

Very best wishes,
Paul

@PaulZC PaulZC merged commit 7005b05 into sparkfun:release_candidate Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hybridOL @PaulZC